65 Matching Annotations
  1. Nov 2022
    1. ul

      noticed that your list is in reverse order when viewed in browser. I also had this problem when floating right. Place your list items contact, portfolio, services, home to have them show as in the example image.

    1. first

      I'm assuming this is old code/old versions of your CSS. I would take this out as GitHub preserves your old versions as long as you're doing frequent commits.

    1. /* I would like to center all of these section articles, but am unsure how to, any help would be appreciated! */

      went back into claire's videos, from Box Model video she talks about centring content. the section on spacing is around 18 minutes in. Essentially you set the width of content in pixels and set horizontal margins to auto.

    1. <img src="images/Screenshot2.jpg" width="700" alt="screencap of website with confusing appearance"/>

      might take the img out of the paragraph, not sure if it's correct/good structure to have it inside

  2. Oct 2022
    1. span

      you don't need the span tags here, the inline style can be applied directly to the h2 element (same with the p element) another option to get the same effect would be to give them both a class="color-white" and apply the style in CSS ex. .color-white{ color: white; }

    1. 20px

      not sure what's going on with the padding (or if the padding is the issue) but, your image is running almost right into your border on the right-hand side.

    2. .card-three .bottom-group {

      for any classes nested within classes, you don't need to call/declare the parent class. If you want the styles applied to .bottom-group you don't need .card-three

    1. <span class="live"> Live </span> <span class="Breaking"> Breaking</span> <span class="UK"> UK </span></p>

      consider doing a return setting each span on a new indented line to make readability easier and make it clearer the spans are nested inside the p

    2. <!-- <div class="dot-group">

      I had to google this to get my dots working. worked out that each empty span needed to be declared as the the class. (not the group they're inside of) then in CSS apply the styles to the dot class. This will give each dot the same style

    3. <!--- I am not happy with the distance apart with my text at the bottom compared to the sample card-->

      This took me forever to get! ended up reducing the top/bottom margins where needed to 0px to get them as close as possible.

    1. /* not sure but there was probably a shorter code style I could of used */

      for the border declarations it can be shortened by using shorthand: border-top: 3px solid hsl(...); this gives all the info in one line of code

    1. footer

      overall site looks great! just a few touchups and everything should be running perfectly! Feel free to shoot me a message on slack if any of my comments don't make sense!

    2. src(topknot.jpg);

      best way to tell CSS where background-image is located is by using url (ex. background-image: url("images/topknot.jpg"); ) also remember to place image sources/urls in quotes

    3. } /* this is not working, help! */

      This isn't working due to an issue in your index file. Your class "topknotimage" is on an empty div element. If you want it to apply to the image/logo you need to EITHER: wrap the image/logo in the div (ex. div class="topknotimage", img src="...", /div) OR apply the class directly to the image (ex. img class="topknotimage" img src="..." )

    1. br

      I like that you've applies these to break up the long lines of text. Maybe update with our new box-model knowledge to create the same effect? Not necessary but maybe a fun exercise.

    1. body

      All looks good! Only suggestion would be to indent your list items within the unordered list, just for readability. One of the formatting extensions SHOULD be able to do that for you.

    1. <!--Receiving an error for my h2 closing tag, unsure-->

      might be because you've closed your h2 before your div. remember opens and closes should mirror eachother. ex) h2, div, content, /div, /h2

    1. .featured-image {

      Ah, I see you've set the width here. I left a comment on the declaration for this image asking for a width dec, please disregard said comment lol.

  3. Sep 2022
    1. <h1> Assignment B </h1>

      here I think you should include structural element to indicate this is the header/title of the page. (like how you used <section> later on)

    1. Nature image"

      great that you've included a description of the image, but would be helpful to have a more detailed description. For example is it a lake, a mountain range? what kind of nature image is this?