- Nov 2022
-
github.com github.com
-
Assignment F
Awesome job! everything looks good, just a couple suggestions on visual formatting!
-
<figure> <!--added figure instead of image, as this is part of the content-->
good point! will have to go back and add this to mine :)
-
h2
these headings should be below/after the placeholder images according to example image.
-
ul
noticed that your list is in reverse order when viewed in browser. I also had this problem when floating right. Place your list items contact, portfolio, services, home to have them show as in the example image.
-
-
github.com github.com
-
first
I'm assuming this is old code/old versions of your CSS. I would take this out as GitHub preserves your old versions as long as you're doing frequent commits.
-
button
you could just call button like you did body or header, since all buttons are getting the same styles.
-
-
github.com github.com
-
body
love your colour choices! super fun and creative, but still easy to read and breaks up content really well!
-
margin: 50px;
refering to above comment: so here you would still have your vertical margins stated, but you would also declare horizontal margins as auto.
-
/* I would like to center all of these section articles, but am unsure how to, any help would be appreciated! */
went back into claire's videos, from Box Model video she talks about centring content. the section on spacing is around 18 minutes in. Essentially you set the width of content in pixels and set horizontal margins to auto.
-
-
github.com github.com
-
article
might wrap this in a header tag to indicate its your title section
-
p
missing its closing tag
-
<h2>Limit your colors</h2>
I like that you've exemplified that in your site by using very colour in a very logical way
-
<img src="images/Screenshot2.jpg" width="700" alt="screencap of website with confusing appearance"/>
might take the img out of the paragraph, not sure if it's correct/good structure to have it inside
-
:
missing a closing p ag here
-
find out information about the store location, contact the store, or shop for items.
great opportunity for a list here!
-
Brenda's Glass Expressions - A glass working store located in Comox Valley.
might make this a heading? it feels more like a subtitle than a paragraph
-
- Oct 2022
-
github.com github.com
-
body
Looks great!
-
<li> 9:00am ~ 5:00pm</li>
tuesday? no day listed on this item
-
-
github.com github.com
-
span
you don't need the span tags here, the inline style can be applied directly to the h2 element (same with the p element) another option to get the same effect would be to give them both a class="color-white" and apply the style in CSS ex. .color-white{ color: white; }
-
div
I would recommend using a p or heading tag (maybe even article?) here, I don't think div is the best option for this
-
-
github.com github.com
-
20px
not sure what's going on with the padding (or if the padding is the issue) but, your image is running almost right into your border on the right-hand side.
-
.card-four
you've got a selector just hanging out all alone here. Is there a reason or just forgotten about?
-
.card-three .bottom-group {
for any classes nested within classes, you don't need to call/declare the parent class. If you want the styles applied to .bottom-group you don't need .card-three
-
images/lion.jpg
we picked the same lion image lol!
-
-
github.com github.com
-
body
overall awesome job! these look great!
-
<span class="live"> Live </span> <span class="Breaking"> Breaking</span> <span class="UK"> UK </span></p>
consider doing a return setting each span on a new indented line to make readability easier and make it clearer the spans are nested inside the p
-
<!-- <div class="dot-group">
I had to google this to get my dots working. worked out that each empty span needed to be declared as the the class. (not the group they're inside of) then in CSS apply the styles to the dot class. This will give each dot the same style
-
<!--- I am not happy with the distance apart with my text at the bottom compared to the sample card-->
This took me forever to get! ended up reducing the top/bottom margins where needed to 0px to get them as close as possible.
-
-
github.com github.com
-
cardfour
Looks great! Maybe add a bit more padding to the text, as it feels a bit tight to the side of the card?
-
.cardthree .comment
there's no need to call cardthree first, you can just call comment. If you want to apply to both classes use a comma in between.
-
/*I cannot get the headline and comment closer together*/
I did this by making the bottom margins for the question 0px and the top margin for the answer 0px.
-
/* I was trying to create the darkness at the bottom to give same effect as Claires photo */
I think it worked pretty well
-
background
is there a reason you have two background colour declarations?
-
/* this may not be what I was suppose to do, hours of trying and it worked */
that's what I got to work too! don't know how else to achieve it
-
greyscale
lol me too! I wasn't a fan of the greyscale look
-
card-one
don't forget to round corners on the card with border-radius. :)
-
/* not sure but there was probably a shorter code style I could of used */
for the border declarations it can be shortened by using shorthand: border-top: 3px solid hsl(...); this gives all the info in one line of code
-
-
github.com github.com
-
footer
overall site looks great! just a few touchups and everything should be running perfectly! Feel free to shoot me a message on slack if any of my comments don't make sense!
-
list-style-type: none;
something is overriding this on your contact page for hours of operation list. Not sure where/why but the list dots are still showing.
-
src(topknot.jpg);
best way to tell CSS where background-image is located is by using url (ex. background-image: url("images/topknot.jpg"); ) also remember to place image sources/urls in quotes
-
} /* this is not working, help! */
This isn't working due to an issue in your index file. Your class "topknotimage" is on an empty div element. If you want it to apply to the image/logo you need to EITHER: wrap the image/logo in the div (ex. div class="topknotimage", img src="...", /div) OR apply the class directly to the image (ex. img class="topknotimage" img src="..." )
-
Html
would put this at the top before any other styles, as this applies to the whole website
-
{
same as above comment. make sure you use selectors otherwise this formatting goes nowhere.
-
{
this isn't applied to anything since you don't have a selector. Example is you wanted this on all body text you could say: body{...}
-
-
github.com github.com
-
id="one"
love the use of and id here, might suggest using a name that tells what is in the element it represents. It makes reading the CSS easier.
-
br
I like that you've applies these to break up the long lines of text. Maybe update with our new box-model knowledge to create the same effect? Not necessary but maybe a fun exercise.
-
Click here
for this I might have just made the phone number the hyperlink, the "click here" throws off the flow when reading it, but the code itself is great!
-
-
github.com github.com
-
body
All looks good! Only suggestion would be to indent your list items within the unordered list, just for readability. One of the formatting extensions SHOULD be able to do that for you.
-
-
github.com github.com
-
div
I would say the div isn't needed here, you can apply the id="selector" to the h2 directly.
-
<!--Receiving an error for my h2 closing tag, unsure-->
might be because you've closed your h2 before your div. remember opens and closes should mirror eachother. ex) h2, div, content, /div, /h2
-
-
github.com github.com
-
div
not sure why you've got these div and p tags here with no content inside?
-
span
not sure you need the span tag here, I think the h3 would have been enough to separate it from the rest.
-
div
make sure to close your p tag before your div or you will have issues.
-
-
github.com github.com
-
.header-img {
I love that you were able to get a background image onto the header section! Looks so great!
-
.featured-image {
Ah, I see you've set the width here. I left a comment on the declaration for this image asking for a width dec, please disregard said comment lol.
-
footer li {
Do you have any footer list items? I couldn't see any, if none are used I would remove this extra code.
-
48px
same with this comment, place next to (or otherwise near) the code it refers to.
-
25.6px
I would place this comment next to the code you're referencing. Right now it's hard to tell what this goes to.
-
-
github.com github.com
-
body
Looks great! comments are super helpful to understand your thoughts/decisions!
-
<!-- I thought it looked better without http showing -->
I like this stylistic choice!
-
<img src="images/the-hairpins-salon.jpeg" class="featured-image" alt="hairpins about page">
Add a width declaration to the here like the hairpins team photo?
-
- Sep 2022
-
github.com github.com
-
<!--Just for fun here is a photo of my kitty-->
I love that you included a photo of your cat! He's very cute :)
-
</p>
would recomend dropping this end tag to the line below, just to make it easier to see the end tag as
is a block level element.
-
<h1> Assignment B </h1>
here I think you should include structural element to indicate this is the header/title of the page. (like how you used <section> later on)
-
-
github.com github.com
-
Nature image"
great that you've included a description of the image, but would be helpful to have a more detailed description. For example is it a lake, a mountain range? what kind of nature image is this?
-