<div class="image_placeholder"> </div>
I can't tell what the function of this div is
31 Matching Annotations
- Nov 2022
-
github.com github.com
-
-
<div class="copyright"> <p> copyright © 2022. All rights reserved North Island College DIGITAL Design + Development </p> </div>
This shouldn't be inside footer, that's why it doesn't have it's own space underneath. It can go right under footer.
-
<div class="wrapper">
everything within this div should be indented once more
-
<div class="hero_content">
This div and its contents should be indented once more
-
<div class="logo"> <img src="images/dgl-logo.png" alt="the dgl logo" style="width:60px"> </div>
I think this can go outside of nav because it's not technically part of navigation. That way you don't need a div for the logo, it can just be in header
-
-
github.com github.com
-
0px;
don't need unit for values of 0
-
.logo{
I think some of your classes may not be needed. The same element could be selected by writing 'header img {}'. Since it is the only image within header it'll be the only element selected.
-
padding-left:10%; padding-right:10%;
This works but a shorter way is to do width: 80%
-
- Oct 2022
-
github.com github.com
-
<main>
Your <main> element encompasses all of the body content, so it seems a bit redundant. I would suggest using main around the 'My analysis, one piece at a time:' section. The content before this is introductory, but the detailed analysis seems to be the actual main content.
-
<div class="card">
These look really nice but could use an article element instead of a div
-
<div> <h2>Business:</h2> <p>Phi Architecture provides customized architectural solutions to its clients and is a company based in Comox. They build solutions that fit clients' needs, aspirations, personalities, budgets, and sites. </p> </div>
Claire mentioned today in class that too many divs can cause code to be harder to read. The purpose here seems to be to organize the code, but using comments to separate sections might do this more cleanly.
-
-
github.com github.com
-
.card{
as mentioned in html file could use article element and avoid class. i like how simple the styling is though.
-
-
github.com github.com
-
url(images/taylor-heery-KT4sScqQx44-unsplash.jpg)
url('images/taylor-heery-KT4sScqQx44-unsplash.jpg')
-
url(images/elephants.jpeg);
url('images/elephants.jpeg'); single quotes around image src
-
background-image: url(images/pexels-janiere-fernandez-13484865.jpg);
the image src should be in single quotation marks url('images/sfrffdfsdf.png')
-
.card-two h2 {
nice
-
-
github.com github.com
-
</h2>
This closing tag can be at the end of line 34 (?)
-
-
github.com github.com
-
<style> h2 a { background-color: black; } </style>
very nice
-
-
github.com github.com
-
Content taken from <a href="https://www.hairpins.ca/">https://www.hairpins.ca/</a>. Used for educational purposes only.
-
Email
mailto: instead of email:
-
"tel:250-b338-7467
"tel:2503387467" no dashes necessary
-
Questions, comments, ready for a new do? We look forward to hearing from you!<br> If you're looking to make an appointment online, please do so here.
-
-
github.com github.com
-
Content taken from <a href="https://www.hairpins.ca/">https://www.hairpins.ca/</a>. Used for educational purposes
-
Range from 45 minutes to 90 minutes <br> Please call us at 250-338-7467 (PINS) to book a shorter appointment for Kid's Cuts, Dry Cuts, Fringe Trims, Neck trims, or Clipper Cut maintenance.
-
Content taken from <a href="https://www.hairpins.ca/">https://www.hairpins.ca/</a> Used for educational purposes only.
Missing
-
<br>Meet the Team<br>
Breaks make sense but this text is not surrounded by an element tag. Something like: <br>
Meet the Team
<br>
makes it possible to format that line.
-
- Sep 2022
-
github.com github.com
-
<p>This is arshdeep singh speaking.</p>
Good practice to put new element on separate line after h1
-
<img src="image/india-amritsar-punjab-golden-temple.jpg" alt="golden temple is beatifull">
So beautiful
-
-
github.com github.com
-
p {color: blue}
Convention is to put a semicolon after blue; I think you're also meant to change the colour of header
-
-
github.com github.com
-
<p>This is Rohan Sharma speaking <p></p>
- It's good practice to put new elements on a new line
- You have two opening paragraph tags (
) before a closing tag (
), paragraph content should be between
-
Document
I think we're supposed to change this to 'Assignment A'
-