20 Matching Annotations
  1. Last 7 days
    1. Add tests for bulk delete too Repeat the same pattern for BulkDeleteWishlists: Owner can bulk delete their wishlists ✅ Non-owner cannot bulk delete someone else's wishlists ❌

      should state that bulk delete does not throw exception, it returns a list of errors.

    1. Java Automapper context works differently than Scala. Instead of using context in transformers, manually set memberId in your service layer after transformation:

      why? this is wrong in my opinion. can use curried functions

    2. Transformer<Wishlist, WishlistDomain, WishlistTransformerContext> wishlistDomainMapper = Transformer.define(Wishlist.class, WishlistDomain.class, WishlistTransformerContext.class) .withFieldComputed(WishlistDomain::email, wishlist -> wishlist.hasEmail() ? wishlist.getEmail().getValue() : "") .withFieldComputed(WishlistDomain::size, wishlist -> wishlist.getItemsList().size()) .build();

      only transformer that needs the ctx

    1. .gdprSupport( builder -> builder.uouAndUserSupport() // ← Use this )

      wrong. use: .gdpr(gdprSpec -> gdprSpec .uouAndUserSupport(AppDefId, contextBuilder.secrets().appSecret()) ) before the change it is: .gdpr(gdprSpec -> gdprSpec .userSupportOnly(AppDefId, contextBuilder.secrets().appSecret()) )

    2. Add a Translator

      add note to put in a new trnaslators file, because when in class mappers the transformers aren't yet build so refrence to the transformer is unknown.