- Nov 2022
-
github.com github.com
-
recent-projects__item
a comment might help the reviewer understand the naming conventions that you'd follow for the project. while there seems to be careful thought put into the naming style, a comment would help understand what to follow or how to follow.
-
h1
there's already a h1 selector that's used in the same piece of code. there seems to be a duplicate.
-
h1, h2, h3, h4, h5, h1 { margin: 0; font-weight: 600; }
I totally understand the readability of this code but maybe formatting elements in a way that they are on the same line instead of a new line for each would help. there actually could be a lot more than 6 elements.
-
-
github.com github.com
-
<span class="copyright" >Copyright © 2022. All rights reserved North Island College DIGITAL Design + Development</span >
This line of code can be formatted more appropriately.
-
- Oct 2022
-
github.com github.com
-
footer {
There could be some consistency in the way spaces are used after a selector
-
h1, h2, h3, h4
having the selectors on multiple lines might not be a great idea. Imagine if there were a lot more than 4.
-
There's an empty space that might not be needed.
-
-
github.com github.com
-
</li> <li>Use the 60-30-10 rule to balance the three colours.</li>
You might want to consider consistency in formatting. In the first one the closing tag of list item is placed on a new line and in the next one it is placed right after the content.
-
id="colours"
Suggestion : Consider using class name over id name if the blocks belong to the same type and would eventually follow the same styling.
-
You've written a very clean and readable code. Loved it.
-
-
github.com github.com
-
'Plan C' rumours grow; Downing Street Christmas party cancelled; warning Scotlands's R number could rise above 2 | COVID latest
there no space between content and tags
-
<button>
increase the size of the button to make it more readable
-
missing carousel dots
-
<link href="https://fonts.googleapis.com/css2?family=Poppins:ital,wght@0,200;0,400;0,600;1,200;1,400;1,600&display=swap" rel="stylesheet">
suggestion : could have href on the same line as link
-
Html code looks well formatted
-
-
github.com github.com
-
Can comment the card two in color gradient as grayscale was mentioned to be for trail purpose only
-
-
github.com github.com
-
h1 {
missing point : h1 font size overriding
-
-
github.com github.com
-
missing comment header in index.html
-
<title>Document</title>
Title needs to describe the webpage
-
- Sep 2022
-
github.com github.com
-
<h2> What are my expectations of this course?</h2>
there's an extra space before the content begins
-
<p>Honestly, I didn't have web experience until this year, the last term I worked on <b>WordPress</b> Projects but it was basic and this semester I am being introduce in how to build a websites with <b>HTML/CSS</b>.
the formatting here makes it difficult to identify where the paragraph tag closes.
-
Loved the fact that you've added comments in the code.
-
-
github.com github.com
-
<footer>copyright @ sunny</footer>
suggesting to start a block level element on a new line since it might not have any relation to the horizontal line that is being used for demarcation
-
<i>
keep the tag along with the content it is related to
-
<h1>
it would be better to start a new block element on a new line for better readability
-
-
github.com github.com
-
</body>
indentation will help for the code be readable when the code is larger
-
alt="Claire Guiot"
It is always better to have 'alt text' for an image describe what the image is as it is best for accessibility and when the image isn't available.
-
<p>This is Gurpal Singh speaking.</p>
for a cleaner code, let new tags begin on a new line.
-