13 Matching Annotations
  1. Oct 2015
  2. Sep 2015
    1. Please stick to strict, 80-column line limits except for small exceptions that would still be readable if they were truncated. Eliminate trailing whitespace wherever possible.

      The .editorconfig file doesn't have rules for this at the moment, though they could be added

    1. Copy your extension’s ID from the chrome://extensions page. Chrome generates this ID the first time you install the extension and will reuse it each time your rebuild or reinstall the extension

      Need to check whether this is actually still necessary or not. The extension ID can be fixed in the manifest to avoid the need for this dance.

    1. Once installed, running nsqd in its default configuration should suffice for integration with h in a development environment

      Running make dev currently succeeds with no warnings or errors if nsqd is not running.

      How do I verify that H is able to communicate with nsqd?

    2. The h project uses ElasticSearch (v1.0 or later) as its principal data store for annotation data, and requires the ElasticSearch ICU Analysis plugin to be installed

      Sounds obvious, but should have a note here about making sure that ES is actually running.

    3. If you don’t have your h/node_modules/.bin directory on your PATH then you’ll get errors because the Node modules you’ve installed can’t be found (for example: Program file not found: uglifyjs). To add the Node modules to your PATH:

      This isn't something you would normally expect to need to do with a node project. Any gulpfiles, Makefiles or other tools should usually reference the binary in ./node_modules/.bin directly. Any particular reason for this?

    1. If you want to annotate a site that’s served over https then you’ll need to serve h over https as well, otherwise the browser will refuse to launch h and give a mixed-content warning.

      Might be a good idea to make this the default recommendation since so much web content is served via HTTPS nowadays.