9 Matching Annotations
  1. May 2020
    1. I encourage people to write good commit messages, with a good description that explains what it does.
    2. Personally I enjoy writing commit messages
    3. It seems weird to me that we are trying to enforce commit messages when they are not really visible or used in the GitLab workflow at all. This is what you see most of the time when interacting with the commit list. I've taken time to compose a nice descriptive body and it is hidden by default:
    4. which might or might not be useful depending on what is the content of the commit.
    5. One way of encouraging users to create good commit message would be to have a better integration with the content of commit message in GitLab itself,
    6. This also ties in the "Single Source Of Truth", where even if I craft descriptive commit messages I will probably have to describe what I did in the MR comments anyways, so that feels like duplicate work.
    7. I never understood why we enforce The commit body must not contain more than 72 characters per line.
    8. It is considerably harder to write proper sentences when you have to insert an enter every now and then just to follow the rule.
  2. Nov 2019
    1. You should not only say what you did, but also why you did it. It’s even more useful if you explain why you did this over any other options.