6 Matching Annotations
  1. Nov 2020
    1. I thought about this while re-reviewing it and think it's probably not a good fit for the Yarn core because the use case is mainly for CI's. I believe that a simple shell script should fix most people's problems.
    1. This is Sass based, and therefore doesn't require Svelte components

      Just because we could make Svelte wrapper components for each Material typography [thing], doesn't mean we should.

      Compare:

      • material-ui [react] did make wrapper components for typography.

        • But why did they? Is there a technical reason why they couldn't just do what svelte-material-ui did (as in, something technical that Svelte empowers/allows?), or did they just not consider it?
      • svelte-material-ui did not.

        • And they were probably wise to not do so. Just reuse the existing work from the Material team so that there's less work for you to keep in sync and less chance of divergence.
  2. Oct 2020
  3. Sep 2020